objtool: Make handle_insn_ops() unconditional (60041bcd) · Commits · 戴 / test

Now that every instruction has a list of stack_ops; we can trivially distinquish those instructions that do not have stack_ops, their list is empty. This means we can now call handle_insn_ops() unconditionally. Suggested-by:

Julien Thierry <jthierry@redhat.com> Signed-off-by:

Peter Zijlstra (Intel) <peterz@infradead.org> Reviewed-by:

Miroslav Benes <mbenes@suse.cz> Acked-by:

Josh Poimboeuf <jpoimboe@redhat.com> Link: https://lkml.kernel.org/r/20200428191659.795115188@infradead.org

tools/objtool/check.c

+3 −5

Original line number	Diff line number	Diff line
		@@ -2259,6 +2259,9 @@ static int validate_branch(struct objtool_file file, struct symbol func,
		return 0;
		}

		if (handle_insn_ops(insn, &state))
		return 1;

		switch (insn->type) {

		case INSN_RETURN:
		@@ -2318,9 +2321,6 @@ static int validate_branch(struct objtool_file file, struct symbol func,
		break;

		case INSN_EXCEPTION_RETURN:
		if (handle_insn_ops(insn, &state))
		return 1;

		/*
		* This handles x86's sync_core() case, where we use an
		* IRET to self. All 'normal' IRET instructions are in
		@@ -2340,8 +2340,6 @@ static int validate_branch(struct objtool_file file, struct symbol func,
		return 0;

		case INSN_STACK:
		if (handle_insn_ops(insn, &state))
		return 1;
		break;

		case INSN_STAC:

Admin message