Commit 5ff7091f authored by David Rientjes's avatar David Rientjes Committed by Linus Torvalds
Browse files

mm, mmu_notifier: annotate mmu notifiers with blockable invalidate callbacks 

Commit 4d4bbd85 ("mm, oom_reaper: skip mm structs with mmu
notifiers") prevented the oom reaper from unmapping private anonymous
memory with the oom reaper when the oom victim mm had mmu notifiers
registered.

The rationale is that doing mmu_notifier_invalidate_range_{start,end}()
around the unmap_page_range(), which is needed, can block and the oom
killer will stall forever waiting for the victim to exit, which may not
be possible without reaping.

That concern is real, but only true for mmu notifiers that have
blockable invalidate_range_{start,end}() callbacks.  This patch adds a
"flags" field to mmu notifier ops that can set a bit to indicate that
these callbacks do not block.

The implementation is steered toward an expensive slowpath, such as
after the oom reaper has grabbed mm->mmap_sem of a still alive oom
victim.

[rientjes@google.com: mmu_notifier_invalidate_range_end() can also call the invalidate_range() must not block, fix comment]
  Link: http://lkml.kernel.org/r/alpine.DEB.2.10.1801091339570.240101@chino.kir.corp.google.com
[akpm@linux-foundation.org: make mm_has_blockable_invalidate_notifiers() return bool, use rwsem_is_locked()]
Link: http://lkml.kernel.org/r/alpine.DEB.2.10.1712141329500.74052@chino.kir.corp.google.com


Signed-off-by: default avatarDavid Rientjes <rientjes@google.com>
Acked-by: default avatarMichal Hocko <mhocko@suse.com>
Acked-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Acked-by: default avatarChristian König <christian.koenig@amd.com>
Acked-by: default avatarDimitri Sivanich <sivanich@hpe.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Oded Gabbay <oded.gabbay@gmail.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Joerg Roedel <joro@8bytes.org>
Cc: Doug Ledford <dledford@redhat.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Mike Marciniszyn <mike.marciniszyn@intel.com>
Cc: Sean Hefty <sean.hefty@intel.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Jérôme Glisse <jglisse@redhat.com>
Cc: Radim Krčmář <rkrcmar@redhat.com>
Signed-off-by: default avatarDavid Rientjes <rientjes@google.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 3b454ad3

drivers/infiniband/hw/hfi1/mmu_rb.c

+1 −0
Original line number Diff line number Diff line
@@ -77,6 +77,7 @@ static void do_remove(struct mmu_rb_handler *handler, 
static void handle_remove(struct work_struct *work);



static const struct mmu_notifier_ops mn_opts = {

	.flags = MMU_INVALIDATE_DOES_NOT_BLOCK,

	.invalidate_range_start = mmu_notifier_range_start,

};

drivers/iommu/amd_iommu_v2.c

+1 −0
Original line number Diff line number Diff line
@@ -427,6 +427,7 @@ static void mn_release(struct mmu_notifier *mn, struct mm_struct *mm) 
}



static const struct mmu_notifier_ops iommu_mn = {

	.flags			= MMU_INVALIDATE_DOES_NOT_BLOCK,

	.release		= mn_release,

	.clear_flush_young      = mn_clear_flush_young,

	.invalidate_range       = mn_invalidate_range,

drivers/iommu/intel-svm.c

+1 −0
Original line number Diff line number Diff line
@@ -276,6 +276,7 @@ static void intel_mm_release(struct mmu_notifier *mn, struct mm_struct *mm) 
}



static const struct mmu_notifier_ops intel_mmuops = {

	.flags = MMU_INVALIDATE_DOES_NOT_BLOCK,

	.release = intel_mm_release,

	.change_pte = intel_change_pte,

	.invalidate_range = intel_invalidate_range,

drivers/misc/sgi-gru/grutlbpurge.c

+1 −0
Original line number Diff line number Diff line
@@ -258,6 +258,7 @@ static void gru_release(struct mmu_notifier *mn, struct mm_struct *mm) 




static const struct mmu_notifier_ops gru_mmuops = {

	.flags			= MMU_INVALIDATE_DOES_NOT_BLOCK,

	.invalidate_range_start	= gru_invalidate_range_start,

	.invalidate_range_end	= gru_invalidate_range_end,

	.release		= gru_release,

include/linux/mmu_notifier.h

+27 −3
Original line number Diff line number Diff line
@@ -2,6 +2,7 @@ 
#ifndef _LINUX_MMU_NOTIFIER_H

#define _LINUX_MMU_NOTIFIER_H



#include <linux/types.h>

#include <linux/list.h>

#include <linux/spinlock.h>

#include <linux/mm_types.h>
@@ -10,6 +11,9 @@ 
struct mmu_notifier;

struct mmu_notifier_ops;



/* mmu_notifier_ops flags */

#define MMU_INVALIDATE_DOES_NOT_BLOCK	(0x01)



#ifdef CONFIG_MMU_NOTIFIER



/*
@@ -26,6 +30,15 @@ struct mmu_notifier_mm { 
};



struct mmu_notifier_ops {

	/*

	 * Flags to specify behavior of callbacks for this MMU notifier.

	 * Used to determine which context an operation may be called.

	 *

	 * MMU_INVALIDATE_DOES_NOT_BLOCK: invalidate_range_* callbacks do not

	 *	block

	 */

	int flags;



	/*

	 * Called either by mmu_notifier_unregister or when the mm is

	 * being destroyed by exit_mmap, always before all pages are
@@ -137,6 +150,10 @@ struct mmu_notifier_ops { 
	 * page. Pages will no longer be referenced by the linux

	 * address space but may still be referenced by sptes until

	 * the last refcount is dropped.

	 *

	 * If both of these callbacks cannot block, and invalidate_range

	 * cannot block, mmu_notifier_ops.flags should have

	 * MMU_INVALIDATE_DOES_NOT_BLOCK set.

	 */

	void (*invalidate_range_start)(struct mmu_notifier *mn,

				       struct mm_struct *mm,
@@ -159,12 +176,13 @@ struct mmu_notifier_ops { 
	 * external TLB range needs to be flushed. For more in depth

	 * discussion on this see Documentation/vm/mmu_notifier.txt

	 *

	 * The invalidate_range() function is called under the ptl

	 * spin-lock and not allowed to sleep.

	 *

	 * Note that this function might be called with just a sub-range

	 * of what was passed to invalidate_range_start()/end(), if

	 * called between those functions.

	 *

	 * If this callback cannot block, and invalidate_range_{start,end}

	 * cannot block, mmu_notifier_ops.flags should have

	 * MMU_INVALIDATE_DOES_NOT_BLOCK set.

	 */

	void (*invalidate_range)(struct mmu_notifier *mn, struct mm_struct *mm,

				 unsigned long start, unsigned long end);
@@ -218,6 +236,7 @@ extern void __mmu_notifier_invalidate_range_end(struct mm_struct *mm, 
				  bool only_end);

extern void __mmu_notifier_invalidate_range(struct mm_struct *mm,

				  unsigned long start, unsigned long end);

extern bool mm_has_blockable_invalidate_notifiers(struct mm_struct *mm);



static inline void mmu_notifier_release(struct mm_struct *mm)

{
@@ -457,6 +476,11 @@ static inline void mmu_notifier_invalidate_range(struct mm_struct *mm, 
{

}



static inline bool mm_has_blockable_invalidate_notifiers(struct mm_struct *mm)

{

	return false;

}



static inline void mmu_notifier_mm_init(struct mm_struct *mm)

{

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE