Commit 5fe9fe3c authored by Zachary Amsden's avatar Zachary Amsden Committed by Linus Torvalds
Browse files

[PATCH] x86: Pnp byte granularity 



The one remaining caller of set_limit, the PnP BIOS code, calls into the PnP
BIOS, passing kernel parameters in and out.  These parameteres may be passed
from arbitrary kernel virtual memory, so they deserve strict protection to
stop a bad BIOS from smashing beyond the object size.

Unfortunately, the use of set_limit was badly botching this by setting the
limit in terms of pages, when it really should have byte granularity.

When doing this, I discovered my BIOS had the buggy code during the "get
system device node" call:

 mov ax, es:[bx]

Which is harmless, but has a trivial workaround.

Signed-off-by: default avatarZachary Amsden <zach@vmware.com>
Cc: "Seth, Rohit" <rohit.seth@intel.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 3fae1c37

arch/i386/kernel/head.S

+6 −6
Original line number Diff line number Diff line
@@ -504,12 +504,12 @@ ENTRY(cpu_gdt_table) 
	.quad 0x0000000000000000	/* 0x80 TSS descriptor */

	.quad 0x0000000000000000	/* 0x88 LDT descriptor */



	/* Segments used for calling PnP BIOS */

	.quad 0x00c09a0000000000	/* 0x90 32-bit code */

	.quad 0x00809a0000000000	/* 0x98 16-bit code */

	.quad 0x0080920000000000	/* 0xa0 16-bit data */

	.quad 0x0080920000000000	/* 0xa8 16-bit data */

	.quad 0x0080920000000000	/* 0xb0 16-bit data */

	/* Segments used for calling PnP BIOS have byte granularity */

	.quad 0x00409a0000000000	/* 0x90 32-bit code */

	.quad 0x00009a0000000000	/* 0x98 16-bit code */

	.quad 0x0000920000000000	/* 0xa0 16-bit data */

	.quad 0x0000920000000000	/* 0xa8 16-bit data */

	.quad 0x0000920000000000	/* 0xb0 16-bit data */



	/*

	 * The APM segments have byte granularity and their bases

drivers/pnp/pnpbios/bioscalls.c

+4 −1
Original line number Diff line number Diff line
@@ -283,12 +283,15 @@ int pnp_bios_dev_node_info(struct pnp_dev_node_info *data) 
static int __pnp_bios_get_dev_node(u8 *nodenum, char boot, struct pnp_bios_node *data)

{

	u16 status;

	u16 tmp_nodenum;

	if (!pnp_bios_present())

		return PNP_FUNCTION_NOT_SUPPORTED;

	if ( !boot && pnpbios_dont_use_current_config )

		return PNP_FUNCTION_NOT_SUPPORTED;

	tmp_nodenum = *nodenum;

	status = call_pnp_bios(PNP_GET_SYS_DEV_NODE, 0, PNP_TS1, 0, PNP_TS2, boot ? 2 : 1, PNP_DS, 0,

			       nodenum, sizeof(char), data, 65536);

			       &tmp_nodenum, sizeof(tmp_nodenum), data, 65536);

	*nodenum = tmp_nodenum;

	return status;

}

include/asm-i386/system.h

+1 −1
Original line number Diff line number Diff line
@@ -54,7 +54,7 @@ __asm__ __volatile__ ("movw %%dx,%1\n\t" \ 
        ); } while(0)



#define set_base(ldt,base) _set_base( ((char *)&(ldt)) , (base) )

#define set_limit(ldt,limit) _set_limit( ((char *)&(ldt)) , ((limit)-1)>>12 )

#define set_limit(ldt,limit) _set_limit( ((char *)&(ldt)) , ((limit)-1) )



/*

 * Load a segment. Fall back on loading the zero

CRA Git | Maintained and supported by SUSTech CRA and CCSE