Unverified Commit 5fd18821 authored Aug 14, 2020 by Rohit kumar Committed by Mark Brown Aug 17, 2020

ASoC: qcom: lpass-platform: fix memory leak



lpass_pcm_data is never freed. Free it in close
ops to avoid memory leak.

Fixes: 022d00ee ("ASoC: lpass-platform: Fix broken pcm data usage")
Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/1597402388-14112-5-git-send-email-rohitkr@codeaurora.org


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 78477186

sound/soc/qcom/lpass-platform.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -61,7 +61,7 @@ static int lpass_platform_pcmops_open(struct snd_soc_component *component,
		int ret, dma_ch, dir = substream->stream;
		struct lpass_pcm_data *data;

		data = devm_kzalloc(soc_runtime->dev, sizeof(*data), GFP_KERNEL);
		data = kzalloc(sizeof(*data), GFP_KERNEL);
		if (!data)
		return -ENOMEM;

		@@ -118,6 +118,7 @@ static int lpass_platform_pcmops_close(struct snd_soc_component *component,
		if (v->free_dma_channel)
		v->free_dma_channel(drvdata, data->dma_ch);

		kfree(data);
		return 0;
		}

Admin message