signals: send_sigqueue: don't forget about handle_stop_signal() (5fc894bb) · Commits · 戴 / test

send_group_sigqueue() calls handle_stop_signal(), send_sigqueue() doesn't. This is not consistent and in fact I'd say this is (minor) bug. Move handle_stop_signal() from send_group_sigqueue() to do_send_sigqueue(), the latter is called by send_sigqueue() too. Signed-off-by:

Oleg Nesterov <oleg@tv-sign.ru> Cc: Roland McGrath <roland@redhat.com> Signed-off-by:

Andrew Morton <akpm@linux-foundation.org> Signed-off-by:

Linus Torvalds <torvalds@linux-foundation.org>

kernel/signal.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -1276,6 +1276,8 @@ void sigqueue_free(struct sigqueue *q)
		static int do_send_sigqueue(int sig, struct sigqueue q, struct task_struct t,
		struct sigpending *pending)
		{
		handle_stop_signal(sig, t);

		if (unlikely(!list_empty(&q->list))) {
		/*
		* If an SI_TIMER entry is already queue just increment
		@@ -1335,7 +1337,6 @@ send_group_sigqueue(int sig, struct sigqueue q, struct task_struct p)
		read_lock(&tasklist_lock);
		/* Since it_lock is held, p->sighand cannot be NULL. */
		spin_lock_irqsave(&p->sighand->siglock, flags);
		handle_stop_signal(sig, p);

		ret = do_send_sigqueue(sig, q, p, &p->signal->shared_pending);

Admin message