net: hns3: remove unnecessary queue reset in the hns3_uninit_all_ring() (5faaf075) · Commits · 戴 / test

It is not necessary to reset the queue in the hns3_uninit_all_ring(), since the queue is stopped in the down operation, and will be reset in the up operation. And the judgment of the HCLGE_STATE_RST_HANDLING flag in the hclge_reset_tqp() is not correct, because we need to reset tqp during pf reset, otherwise it may cause queue not being reset to working state problem. Fixes: ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC") Signed-off-by:

Huazhong Tan <tanhuazhong@huawei.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -3250,9 +3250,6 @@ int hns3_uninit_all_ring(struct hns3_nic_priv *priv)
		int i;

		for (i = 0; i < h->kinfo.num_tqps; i++) {
		if (h->ae_algo->ops->reset_queue)
		h->ae_algo->ops->reset_queue(h, i);

		hns3_fini_ring(priv->ring_data[i].ring);
		hns3_fini_ring(priv->ring_data[i + h->kinfo.num_tqps].ring);
		}

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -6116,9 +6116,6 @@ void hclge_reset_tqp(struct hnae3_handle *handle, u16 queue_id)
		u16 queue_gid;
		int ret;

		if (test_bit(HCLGE_STATE_RST_HANDLING, &hdev->state))
		return;

		queue_gid = hclge_covert_handle_qid_global(handle, queue_id);

		ret = hclge_tqp_enable(hdev, queue_id, 0, false);

Admin message