Commit 5fa9041b authored Nov 29, 2012 by Namhyung Kim Committed by Arnaldo Carvalho de Melo Dec 09, 2012

perf hists: Link hist entry pairs to leader

Current hists__match/link() link a leader to its pair, so if multiple
pairs were linked, the leader will lose pointer to previous pairs since
it was overwritten.  Fix it by making leader the list head.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1354171126-14387-8-git-send-email-namhyung@kernel.org

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 2850d948

tools/perf/util/hist.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -785,7 +785,7 @@ void hists__match(struct hists leader, struct hists other)
		pair = hists__find_entry(other, pos);

		if (pair)
		hist_entry__add_pair(pos, pair);
		hist_entry__add_pair(pair, pos);
		}
		}

		@@ -806,7 +806,7 @@ int hists__link(struct hists leader, struct hists other)
		pair = hists__add_dummy_entry(leader, pos);
		if (pair == NULL)
		return -1;
		hist_entry__add_pair(pair, pos);
		hist_entry__add_pair(pos, pair);
		}
		}

Admin message