Commit 5f982c70 authored May 22, 2015 by Grygorii Strashko Committed by Linus Walleij Jun 01, 2015

gpio: omap: fix omap_gpio_free to not clean up irq configuration



This patch fixes following issue:
- GPIOn is used as IRQ by some dev, for example PCF8575.INT ->  gpio6.11
- PCFx driver knows nothing about type of IRQ line (GPIO or not)
  so it doesn't request gpio and just do request_irq()
- If gpio6.11 will be exported through the sysfs and then un-xeported
then IRQs from PCFx will not be received any more, because
IRQ configuration for gpio6.11 will be cleaned up unconditionally
in omap_gpio_free.

Fix this by removing all GPIO IRQ specific code from omap_gpio_free()
and also do GPIO clean up (change direction to 'in' and disable debounce)
only if corresponding GPIO is not used as IRQ too.
GPIO IRQ will be properly cleaned up by GPIO irqchip code.

Signed-off-by: Grygorii Strashko <grygorii.strashko@linaro.org>
Tested-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 501ef0f9

drivers/gpio/gpio-omap.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -690,8 +690,11 @@ static void omap_gpio_free(struct gpio_chip *chip, unsigned offset)

		spin_lock_irqsave(&bank->lock, flags);
		bank->mod_usage &= ~(BIT(offset));
		if (!LINE_USED(bank->irq_usage, offset)) {
		omap_set_gpio_direction(bank, offset, 1);
		omap_clear_gpio_debounce(bank, offset);
		}
		omap_disable_gpio_module(bank, offset);
		omap_reset_gpio(bank, offset);
		spin_unlock_irqrestore(&bank->lock, flags);

		/*

Admin message