Commit 5f8b4d5d authored Aug 09, 2019 by Arnaldo Carvalho de Melo

perf hist: Remove dummy entries when finding real ones.

When he have an event group we have multiple struct hist instances, one
per evsel, and in each of these hists we may have hist_entries that
point to the same thing being observed, say a symbol, i.e. if we're
looking at instructions and cycles, then we'll have one hist_entry in
the "instructions" evsel and another in the "cycles" evsel.

We need to link those to then show one column for each. When we're
looking at some other pair of events, say instructions and cache misses,
we may have just the "instructions" hist entry and not one for "cache
misses", as instructions not necessarily generate cache misses, as the
logic expects one hist_entry per evsel, we end up adding "dummy"
hist_entries.

This is enough for 'perf report', that does this matching operation
(hists__match()) just once after processing all events, but for 'perf
top', we do this at each refresh, so we may finally find events matching
and then we need to trow away the dummies and link with the real events.

So if we find a match, traverse the link of matches and trow away
dummies for that hists.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lkml.kernel.org/n/tip-dwvtjqqifsbsczeb35q6mqkk@git.kernel.org


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 3e70008a

tools/perf/util/hist.c

+18 −2

Original line number	Diff line number	Diff line
		@@ -2436,7 +2436,7 @@ void hists__match(struct hists leader, struct hists other)
		{
		struct rb_root_cached *root;
		struct rb_node *nd;
		struct hist_entry pos, pair;
		struct hist_entry pos, pair, pos_pair, tmp_pair;

		if (symbol_conf.report_hierarchy) {
		/* hierarchy report always collapses entries */
		@@ -2453,10 +2453,26 @@ void hists__match(struct hists leader, struct hists other)
		pos = rb_entry(nd, struct hist_entry, rb_node_in);
		pair = hists__find_entry(other, pos);

		if (pair && list_empty(&pair->pairs.node))
		if (pair && list_empty(&pair->pairs.node)) {
		list_for_each_entry_safe(pos_pair, tmp_pair, &pos->pairs.head, pairs.node) {
		if (pos_pair->hists == other) {
		/*
		* XXX maybe decayed entries can appear
		* here? but then we would have use
		* after free, as decayed entries are
		* freed see hists__delete_entry
		*/
		BUG_ON(!pos_pair->dummy);
		list_del_init(&pos_pair->pairs.node);
		hist_entry__delete(pos_pair);
		break;
		}
		}

		hist_entry__add_pair(pair, pos);
		}
		}
		}

		static int hists__link_hierarchy(struct hists *leader_hists,
		struct hist_entry *parent,

Admin message