Commit 5f7fb6f1 authored Apr 18, 2016 by H. Nikolaus Schaller Committed by Dmitry Torokhov Apr 19, 2016

Input: twl6040-vibra - ignore return value of schedule_work



Returning ret is wrong. And checking for an error as well. User space
may call multiple times until the work is really scheduled.

twl4030-vibra.c also ignores the return value.

Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

parent 52dee2c9

drivers/input/misc/twl6040-vibra.c

+1 −5

Original line number	Diff line number	Diff line
		@@ -212,11 +212,7 @@ static int vibra_play(struct input_dev input, void data,
		info->strong_speed = effect->u.rumble.strong_magnitude;
		info->direction = effect->direction < EFFECT_DIR_180_DEG ? 1 : -1;

		ret = schedule_work(&info->play_work);
		if (!ret) {
		dev_info(&input->dev, "work is already on queue\n");
		return ret;
		}
		schedule_work(&info->play_work);

		return 0;
		}

Admin message