Commit 5f755e1f authored by Light Hsieh's avatar Light Hsieh Committed by Linus Walleij
Browse files

pinctrl: mediatek: Supporting driving setting without mapping current to register value 



MediaTek's smartphone project actual usage does need to know current value
(in mA) in procedure of finding the best driving setting.
The steps in the procedure is like as follow:

1. set driving setting field in setting register as 0, measure waveform,
   perform test, and etc.
2. set driving setting field in setting register as 1, measure waveform,
   perform test, and etc.
...
n. set driving setting field in setting register as n-1, measure
   waveform, perform test, and etc.
Check the results of steps 1~n and adopt the setting that get best result.

This procedure does need to know the mapping between current to register
value.
Therefore, setting driving without mapping current is more practical for
MediaTek's smartphone usage.

Signed-off-by: default avatarLight Hsieh <light.hsieh@mediatek.com>
Link: https://lore.kernel.org/r/1579675994-7001-2-git-send-email-light.hsieh@mediatek.com


Acked-by: default avatarSean Wang <sean.wang@kernel.org>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 3de7deef

drivers/pinctrl/mediatek/pinctrl-mt6765.c

+2 −2
Original line number Diff line number Diff line
@@ -1077,8 +1077,8 @@ static const struct mtk_pin_soc mt6765_data = { 
	.bias_disable_get = mtk_pinconf_bias_disable_get,

	.bias_set = mtk_pinconf_bias_set,

	.bias_get = mtk_pinconf_bias_get,

	.drive_set = mtk_pinconf_drive_set_rev1,

	.drive_get = mtk_pinconf_drive_get_rev1,

	.drive_set = mtk_pinconf_drive_set_raw,

	.drive_get = mtk_pinconf_drive_get_raw,

	.adv_pull_get = mtk_pinconf_adv_pull_get,

	.adv_pull_set = mtk_pinconf_adv_pull_set,

};

drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c

+12 −0
Original line number Diff line number Diff line
@@ -608,6 +608,18 @@ int mtk_pinconf_drive_get_rev1(struct mtk_pinctrl *hw, 
	return 0;

}



int mtk_pinconf_drive_set_raw(struct mtk_pinctrl *hw,

			       const struct mtk_pin_desc *desc, u32 arg)

{

	return mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_DRV, arg);

}



int mtk_pinconf_drive_get_raw(struct mtk_pinctrl *hw,

			       const struct mtk_pin_desc *desc, int *val)

{

	return mtk_hw_get_value(hw, desc, PINCTRL_PIN_REG_DRV, val);

}



int mtk_pinconf_adv_pull_set(struct mtk_pinctrl *hw,

			     const struct mtk_pin_desc *desc, bool pullup,

			     u32 arg)

drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h

+5 −0
Original line number Diff line number Diff line
@@ -288,6 +288,11 @@ int mtk_pinconf_drive_set_rev1(struct mtk_pinctrl *hw, 
int mtk_pinconf_drive_get_rev1(struct mtk_pinctrl *hw,

			       const struct mtk_pin_desc *desc, int *val);



int mtk_pinconf_drive_set_raw(struct mtk_pinctrl *hw,

			       const struct mtk_pin_desc *desc, u32 arg);

int mtk_pinconf_drive_get_raw(struct mtk_pinctrl *hw,

			       const struct mtk_pin_desc *desc, int *val);



int mtk_pinconf_adv_pull_set(struct mtk_pinctrl *hw,

			     const struct mtk_pin_desc *desc, bool pullup,

			     u32 arg);

CRA Git | Maintained and supported by SUSTech CRA and CCSE