Commit 5f70bf75 authored by Henrique de Moraes Holschuh's avatar Henrique de Moraes Holschuh Committed by Len Brown
Browse files

ACPI: thinkpad-acpi: change thinkpad-acpi input default and kconfig help 



The current kconfig help text was misleading users.  Also, the default for
an input-layer-optimized support caused way too many problems without
up-to-date userspace in place.

So, rework the help text, and change the default to N.  Note that
distributions are supposed to enable this option as soon as they update HAL
to a version that handles the thinkpad-acpi new input layer interface.

Signed-off-by: default avatarHenrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Michael S. Tsirkin <mst@dev.mellanox.co.il>
Cc: Hugh Dickins <hugh@veritas.com>
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent ac36393d

drivers/misc/Kconfig

+15 −7
Original line number Diff line number Diff line
@@ -200,14 +200,22 @@ config THINKPAD_ACPI_BAY 
config THINKPAD_ACPI_INPUT_ENABLED

	bool "Enable input layer support by default"

	depends on THINKPAD_ACPI

	default y

	default n

	---help---

	  Enables hot key handling over the input layer by default.  If unset,

	  the driver does not enable any hot key handling by default, and also

	  starts up with a mostly empty keymap.



	  If you are not sure, say Y here.  Say N to retain the deprecated

	  behavior of ibm-acpi, and thinkpad-acpi for kernels up to 2.6.21.

	  This option enables thinkpad-acpi hot key handling over the input

	  layer at driver load time.  When it is unset, the driver does not

	  enable hot key handling by default, and also starts up with a mostly

	  empty keymap.



	  This option should be enabled if you have a new enough HAL or other

	  userspace support that properly handles the thinkpad-acpi event

	  device.  It auto-tunes the hot key support to those reported by the

	  firmware and enables it automatically.



	  If unsure, say N here to retain the old behaviour of ibm-acpi, and

	  thinkpad-acpi up to kernel 2.6.21: userspace will have to enable and

	  set up the thinkpad-acpi hot key handling using the sysfs interace

	  after loading the driver.





endif # MISC_DEVICES

CRA Git | Maintained and supported by SUSTech CRA and CCSE