cm4000_cs.c cmm_ioctl(): get rid of pointless access_ok() (5f599098) · Commits · 戴 / test

drivers/char/pcmcia/cm4000_cs.c

+0 −14

Original line number	Diff line number	Diff line
		@@ -1404,7 +1404,6 @@ static long cmm_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
		unsigned int iobase = dev->p_dev->resource[0]->start;
		struct inode *inode = file_inode(filp);
		struct pcmcia_device *link;
		int size;
		int rc;
		void __user argp = (void __user )arg;
		#ifdef CM4000_DEBUG
		@@ -1441,19 +1440,6 @@ static long cmm_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
		DEBUGP(4, dev, "iocnr mismatch\n");
		goto out;
		}
		size = _IOC_SIZE(cmd);
		rc = -EFAULT;
		DEBUGP(4, dev, "iocdir=%.4x iocr=%.4x iocw=%.4x iocsize=%d cmd=%.4x\n",
		_IOC_DIR(cmd), _IOC_READ, _IOC_WRITE, size, cmd);

		if (_IOC_DIR(cmd) & _IOC_READ) {
		if (!access_ok(argp, size))
		goto out;
		}
		if (_IOC_DIR(cmd) & _IOC_WRITE) {
		if (!access_ok(argp, size))
		goto out;
		}
		rc = 0;

		switch (cmd) {