Commit 5f4eedef authored May 15, 2015 by Fabio Estevam Committed by Dmitry Torokhov May 15, 2015

Input: twl4030-pwrbutton - pass the IRQF_ONESHOT flag



Since commit 1c6c6952 ("genirq: Reject
bogus threaded irq requests") threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request will fail.

So pass the IRQF_ONESHOT flag in this case.

The semantic patch that makes this change is available
in scripts/coccinelle/misc/irqf_oneshot.cocci.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

parent 68aeee98

drivers/input/misc/twl4030-pwrbutton.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -71,7 +71,8 @@ static int twl4030_pwrbutton_probe(struct platform_device *pdev)
		pwr->dev.parent = &pdev->dev;

		err = devm_request_threaded_irq(&pwr->dev, irq, NULL, powerbutton_irq,
		IRQF_TRIGGER_FALLING \| IRQF_TRIGGER_RISING,
		IRQF_TRIGGER_FALLING \| IRQF_TRIGGER_RISING \|
		IRQF_ONESHOT,
		"twl4030_pwrbutton", pwr);
		if (err < 0) {
		dev_err(&pdev->dev, "Can't get IRQ for pwrbutton: %d\n", err);

Admin message