Commit 5f2eecef authored by Andrii Nakryiko's avatar Andrii Nakryiko Committed by Alexei Starovoitov
Browse files

selftests/bpf: Add flexible array relocation tests 



Add few tests validation CO-RE relocation handling of flexible array accesses.

Signed-off-by: default avatarAndrii Nakryiko <andriin@fb.com>
Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20191215070844.1014385-3-andriin@fb.com
parent 1b484b30

tools/testing/selftests/bpf/prog_tests/core_reloc.c

+4 −0
Original line number Diff line number Diff line
@@ -74,6 +74,7 @@ 
		.b123 = 2,						\

		.c1c  = 3,						\

		.d00d = 4,						\

		.f10c = 0,						\

	},								\

	.output_len = sizeof(struct core_reloc_arrays_output)		\

}
@@ -308,12 +309,15 @@ static struct core_reloc_test_case test_cases[] = { 
	ARRAYS_CASE(arrays),

	ARRAYS_CASE(arrays___diff_arr_dim),

	ARRAYS_CASE(arrays___diff_arr_val_sz),

	ARRAYS_CASE(arrays___equiv_zero_sz_arr),

	ARRAYS_CASE(arrays___fixed_arr),



	ARRAYS_ERR_CASE(arrays___err_too_small),

	ARRAYS_ERR_CASE(arrays___err_too_shallow),

	ARRAYS_ERR_CASE(arrays___err_non_array),

	ARRAYS_ERR_CASE(arrays___err_wrong_val_type1),

	ARRAYS_ERR_CASE(arrays___err_wrong_val_type2),

	ARRAYS_ERR_CASE(arrays___err_bad_zero_sz_arr),



	/* enum/ptr/int handling scenarios */

	PRIMITIVES_CASE(primitives),

tools/testing/selftests/bpf/progs/btf__core_reloc_arrays___equiv_zero_sz_arr.c

0 → 100644
+3 −0
Original line number Diff line number Diff line 
#include "core_reloc_types.h"



void f(struct core_reloc_arrays___equiv_zero_sz_arr x) {}

tools/testing/selftests/bpf/progs/btf__core_reloc_arrays___err_bad_zero_sz_arr.c

0 → 100644
+3 −0
Original line number Diff line number Diff line 
#include "core_reloc_types.h"



void f(struct core_reloc_arrays___err_bad_zero_sz_arr x) {}

tools/testing/selftests/bpf/progs/btf__core_reloc_arrays___fixed_arr.c

0 → 100644
+3 −0
Original line number Diff line number Diff line 
#include "core_reloc_types.h"



void f(struct core_reloc_arrays___fixed_arr x) {}

tools/testing/selftests/bpf/progs/core_reloc_types.h

+39 −0
Original line number Diff line number Diff line
@@ -327,6 +327,7 @@ struct core_reloc_arrays_output { 
	char b123;

	int c1c;

	int d00d;

	int f10c;

};



struct core_reloc_arrays_substruct {
@@ -339,6 +340,7 @@ struct core_reloc_arrays { 
	char b[2][3][4];

	struct core_reloc_arrays_substruct c[3];

	struct core_reloc_arrays_substruct d[1][2];

	struct core_reloc_arrays_substruct f[][2];

};



/* bigger array dimensions */
@@ -347,6 +349,7 @@ struct core_reloc_arrays___diff_arr_dim { 
	char b[3][4][5];

	struct core_reloc_arrays_substruct c[4];

	struct core_reloc_arrays_substruct d[2][3];

	struct core_reloc_arrays_substruct f[1][3];

};



/* different size of array's value (struct) */
@@ -363,6 +366,29 @@ struct core_reloc_arrays___diff_arr_val_sz { 
		int d;

		int __padding2;

	} d[1][2];

	struct {

		int __padding1;

		int c;

		int __padding2;

	} f[][2];

};



struct core_reloc_arrays___equiv_zero_sz_arr {

	int a[5];

	char b[2][3][4];

	struct core_reloc_arrays_substruct c[3];

	struct core_reloc_arrays_substruct d[1][2];

	/* equivalent to flexible array */

	struct core_reloc_arrays_substruct f[0][2];

};



struct core_reloc_arrays___fixed_arr {

	int a[5];

	char b[2][3][4];

	struct core_reloc_arrays_substruct c[3];

	struct core_reloc_arrays_substruct d[1][2];

	/* not a flexible array anymore, but within access bounds */

	struct core_reloc_arrays_substruct f[1][2];

};



struct core_reloc_arrays___err_too_small {
@@ -370,6 +396,7 @@ struct core_reloc_arrays___err_too_small { 
	char b[2][3][4];

	struct core_reloc_arrays_substruct c[3];

	struct core_reloc_arrays_substruct d[1][2];

	struct core_reloc_arrays_substruct f[][2];

};



struct core_reloc_arrays___err_too_shallow {
@@ -377,6 +404,7 @@ struct core_reloc_arrays___err_too_shallow { 
	char b[2][3]; /* this one lacks one dimension */

	struct core_reloc_arrays_substruct c[3];

	struct core_reloc_arrays_substruct d[1][2];

	struct core_reloc_arrays_substruct f[][2];

};



struct core_reloc_arrays___err_non_array {
@@ -384,6 +412,7 @@ struct core_reloc_arrays___err_non_array { 
	char b[2][3][4];

	struct core_reloc_arrays_substruct c[3];

	struct core_reloc_arrays_substruct d[1][2];

	struct core_reloc_arrays_substruct f[][2];

};



struct core_reloc_arrays___err_wrong_val_type {
@@ -391,6 +420,16 @@ struct core_reloc_arrays___err_wrong_val_type { 
	char b[2][3][4];

	int c[3]; /* value is not a struct */

	struct core_reloc_arrays_substruct d[1][2];

	struct core_reloc_arrays_substruct f[][2];

};



struct core_reloc_arrays___err_bad_zero_sz_arr {

	/* zero-sized array, but not at the end */

	struct core_reloc_arrays_substruct f[0][2];

	int a[5];

	char b[2][3][4];

	struct core_reloc_arrays_substruct c[3];

	struct core_reloc_arrays_substruct d[1][2];

};



/*

CRA Git | Maintained and supported by SUSTech CRA and CCSE