Commit 5f186110 authored by Devendra Naga's avatar Devendra Naga Committed by Greg Kroah-Hartman
Browse files

staging: clocking-wizard: check for a valid clk_name pointer 



The clk_name gets the return value from kasprintf (part of which does the
allocation of the returned buffer). So check the return pointer
before using it for clk_register_fixed_factor.

Signed-off-by: default avatarDevendra Naga <devendra.aaru@gmail.com>
Reviewed-by: default avatarSoren Brinkmann <soren.brinkmann@xilinx.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 315f9a2f

drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c

+5 −0
Original line number Diff line number Diff line
@@ -221,6 +221,11 @@ static int clk_wzrd_probe(struct platform_device *pdev) 
	reg = (readl(clk_wzrd->base + WZRD_CLK_CFG_REG(0)) &

			WZRD_DIVCLK_DIVIDE_MASK) >> WZRD_DIVCLK_DIVIDE_SHIFT;

	clk_name = kasprintf(GFP_KERNEL, "%s_mul_div", dev_name(&pdev->dev));

	if (!clk_name) {

		ret = -ENOMEM;

		goto err_rm_int_clk;

	}



	clk_wzrd->clks_internal[wzrd_clk_mul_div] = clk_register_fixed_factor(

			&pdev->dev, clk_name,

			__clk_get_name(clk_wzrd->clks_internal[wzrd_clk_mul]),

CRA Git | Maintained and supported by SUSTech CRA and CCSE