Commit 5ef753ae authored by Oliver O'Halloran's avatar Oliver O'Halloran Committed by Michael Ellerman
Browse files

powerpc/eeh: Fix race when freeing PDNs 



When hot-adding devices we rely on the hotplug driver to create pci_dn's
for the devices under the hotplug slot. Converse, when hot-removing the
driver will remove the pci_dn's that it created. This is a problem because
the pci_dev is still live until it's refcount drops to zero. This can
happen if the driver is slow to tear down it's internal state. Ideally, the
driver would not attempt to perform any config accesses to the device once
it's been marked as removed, but sometimes it happens. As a result, we
might attempt to access the pci_dn for a device that has been torn down and
the kernel may crash as a result.

To fix this, don't free the pci_dn unless the corresponding pci_dev has
been released.  If the pci_dev is still live, then we mark the pci_dn with
a flag that indicates the pci_dev's release function should free it.

Signed-off-by: default avatarOliver O'Halloran <oohall@gmail.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20190903101605.2890-3-oohall@gmail.com
parent 799abe28

arch/powerpc/include/asm/pci-bridge.h

+1 −0
Original line number Diff line number Diff line
@@ -183,6 +183,7 @@ struct iommu_table; 
struct pci_dn {

	int     flags;

#define PCI_DN_FLAG_IOV_VF	0x01

#define PCI_DN_FLAG_DEAD	0x02    /* Device has been hot-removed */



	int	busno;			/* pci bus number */

	int	devfn;			/* pci device and function number */

arch/powerpc/kernel/pci-hotplug.c

+7 −0
Original line number Diff line number Diff line
@@ -55,11 +55,18 @@ EXPORT_SYMBOL_GPL(pci_find_bus_by_node); 
void pcibios_release_device(struct pci_dev *dev)

{

	struct pci_controller *phb = pci_bus_to_host(dev->bus);

	struct pci_dn *pdn = pci_get_pdn(dev);



	eeh_remove_device(dev);



	if (phb->controller_ops.release_device)

		phb->controller_ops.release_device(dev);



	/* free()ing the pci_dn has been deferred to us, do it now */

	if (pdn && (pdn->flags & PCI_DN_FLAG_DEAD)) {

		pci_dbg(dev, "freeing dead pdn\n");

		kfree(pdn);

	}

}



/**

arch/powerpc/kernel/pci_dn.c

+19 −2
Original line number Diff line number Diff line
@@ -323,6 +323,7 @@ void pci_remove_device_node_info(struct device_node *dn) 
{

	struct pci_dn *pdn = dn ? PCI_DN(dn) : NULL;

	struct device_node *parent;

	struct pci_dev *pdev;

#ifdef CONFIG_EEH

	struct eeh_dev *edev = pdn_to_eeh_dev(pdn);
@@ -336,13 +337,29 @@ void pci_remove_device_node_info(struct device_node *dn) 
	WARN_ON(!list_empty(&pdn->child_list));

	list_del(&pdn->list);



	/* Drop the parent pci_dn's ref to our backing dt node */

	parent = of_get_parent(dn);

	if (parent)

		of_node_put(parent);



	/*

	 * At this point we *might* still have a pci_dev that was

	 * instantiated from this pci_dn. So defer free()ing it until

	 * the pci_dev's release function is called.

	 */

	pdev = pci_get_domain_bus_and_slot(pdn->phb->global_number,

			pdn->busno, pdn->devfn);

	if (pdev) {

		/* NB: pdev has a ref to dn */

		pci_dbg(pdev, "marked pdn (from %pOF) as dead\n", dn);

		pdn->flags |= PCI_DN_FLAG_DEAD;

	} else {

		dn->data = NULL;

		kfree(pdn);

	}



	pci_dev_put(pdev);

}

EXPORT_SYMBOL_GPL(pci_remove_device_node_info);



/*

CRA Git | Maintained and supported by SUSTech CRA and CCSE