Commit 5ef4414f authored Aug 19, 2013 by Richard Weinberger Committed by Artem Bityutskiy Aug 19, 2013

UBI: Fix PEB leak in wear_leveling_worker()



get_peb_for_wl() removes the PEB from the free list.
If the WL subsystem detects that no wear leveling is needed
it cancels the operation and drops the gained PEB.
In this case we have to put the PEB back into the free list.

This issue was introduced with commit ed4b7021
(UBI: remove PEB from free tree in get_peb_for_wl()).

Cc: <stable@vger.kernel.org> # 3.7.x
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

parent b36f4be3

drivers/mtd/ubi/wl.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -1069,6 +1069,9 @@ static int wear_leveling_worker(struct ubi_device ubi, struct ubi_work wrk,
		if (!(e2->ec - e1->ec >= UBI_WL_THRESHOLD)) {
		dbg_wl("no WL needed: min used EC %d, max free EC %d",
		e1->ec, e2->ec);

		/* Give the unused PEB back */
		wl_tree_add(e2, &ubi->free);
		goto out_cancel;
		}
		self_check_in_wl_tree(ubi, e1, &ubi->used);

Admin message