Commit 5ee0844d authored by Stefan Behrens's avatar Stefan Behrens Committed by Chris Mason
Browse files

Btrfs: revert checksum error statistic which can cause a BUG() 



Commit 442a4f63 added btrfs device
statistic counters for detected IO and checksum errors to Linux 3.5.
The statistic part that counts checksum errors in
end_bio_extent_readpage() can cause a BUG() in a subfunction:
"kernel BUG at fs/btrfs/volumes.c:3762!"
That part is reverted with the current patch.
However, the counting of checksum errors in the scrub context remains
active, and the counting of detected IO errors (read, write or flush
errors) in all contexts remains active.

Cc: stable <stable@vger.kernel.org> # 3.5
Signed-off-by: default avatarStefan Behrens <sbehrens@giantdisaster.de>
Signed-off-by: default avatarChris Mason <chris.mason@oracle.com>
parent 68ce9682

fs/btrfs/extent_io.c

+2 −15
Original line number Diff line number Diff line
@@ -2329,24 +2329,11 @@ static void end_bio_extent_readpage(struct bio *bio, int err) 
		if (uptodate && tree->ops && tree->ops->readpage_end_io_hook) {

			ret = tree->ops->readpage_end_io_hook(page, start, end,

							      state, mirror);

			if (ret) {

				/* no IO indicated but software detected errors

				 * in the block, either checksum errors or

				 * issues with the contents */

				struct btrfs_root *root =

					BTRFS_I(page->mapping->host)->root;

				struct btrfs_device *device;



			if (ret)

				uptodate = 0;

				device = btrfs_find_device_for_logical(

						root, start, mirror);

				if (device)

					btrfs_dev_stat_inc_and_print(device,

						BTRFS_DEV_STAT_CORRUPTION_ERRS);

			} else {

			else

				clean_io_failure(start, page);

		}

		}



		if (!uptodate && tree->ops && tree->ops->readpage_io_failed_hook) {

			ret = tree->ops->readpage_io_failed_hook(page, mirror);

fs/btrfs/volumes.c

+0 −22
Original line number Diff line number Diff line
@@ -4610,28 +4610,6 @@ int btrfs_read_sys_array(struct btrfs_root *root) 
	return ret;

}



struct btrfs_device *btrfs_find_device_for_logical(struct btrfs_root *root,

						   u64 logical, int mirror_num)

{

	struct btrfs_mapping_tree *map_tree = &root->fs_info->mapping_tree;

	int ret;

	u64 map_length = 0;

	struct btrfs_bio *bbio = NULL;

	struct btrfs_device *device;



	BUG_ON(mirror_num == 0);

	ret = btrfs_map_block(map_tree, WRITE, logical, &map_length, &bbio,

			      mirror_num);

	if (ret) {

		BUG_ON(bbio != NULL);

		return NULL;

	}

	BUG_ON(mirror_num != bbio->mirror_num);

	device = bbio->stripes[mirror_num - 1].dev;

	kfree(bbio);

	return device;

}



int btrfs_read_chunk_tree(struct btrfs_root *root)

{

	struct btrfs_path *path;

fs/btrfs/volumes.h

+0 −2
Original line number Diff line number Diff line
@@ -289,8 +289,6 @@ int btrfs_cancel_balance(struct btrfs_fs_info *fs_info); 
int btrfs_chunk_readonly(struct btrfs_root *root, u64 chunk_offset);

int find_free_dev_extent(struct btrfs_device *device, u64 num_bytes,

			 u64 *start, u64 *max_avail);

struct btrfs_device *btrfs_find_device_for_logical(struct btrfs_root *root,

						   u64 logical, int mirror_num);

void btrfs_dev_stat_print_on_error(struct btrfs_device *device);

void btrfs_dev_stat_inc_and_print(struct btrfs_device *dev, int index);

int btrfs_get_dev_stats(struct btrfs_root *root,

CRA Git | Maintained and supported by SUSTech CRA and CCSE