Commit 5ec9c177 authored Oct 09, 2013 by Hans de Goede Committed by Sarah Sharp Mar 04, 2014

usbfs: Kill urbs on interface before doing a set_interface



The usb_set_interface documentation says:

 * Also, drivers must not change altsettings while urbs are scheduled for
 * endpoints in that interface; all such urbs must first be completed
 * (perhaps forced by unlinking).

For in kernel drivers we trust the drivers to get this right, but we
cannot trust userspace to get this right, so enforce it by killing any
urbs still pending on the interface.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>

parent 6343e8bf

drivers/usb/core/devio.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -1143,6 +1143,9 @@ static int proc_setintf(struct dev_state ps, void __user arg)
		return -EFAULT;
		if ((ret = checkintf(ps, setintf.interface)))
		return ret;

		destroy_async_on_interface(ps, setintf.interface);

		return usb_set_interface(ps->dev, setintf.interface,
		setintf.altsetting);
		}

Admin message