Commit 5ec8b75e authored Oct 18, 2008 by Aneesh Kumar K.V Committed by Linus Torvalds Oct 20, 2008

ext3: truncate block allocated on a failed ext3_write_begin

For blocksize < pagesize we need to remove blocks that got allocated in
block_write_begin() if we fail with ENOSPC for later blocks.
block_write_begin() internally does this if it allocated page locally.
This makes sure we don't have blocks outside inode.i_size during ENOSPC.

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 6a897cf4

fs/ext3/inode.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -1186,6 +1186,13 @@ write_begin_failed:
		ext3_journal_stop(handle);
		unlock_page(page);
		page_cache_release(page);
		/*
		* block_write_begin may have instantiated a few blocks
		* outside i_size. Trim these off again. Don't need
		* i_size_read because we hold i_mutex.
		*/
		if (pos + len > inode->i_size)
		vmtruncate(inode, inode->i_size);
		}
		if (ret == -ENOSPC && ext3_should_retry_alloc(inode->i_sb, &retries))
		goto retry;