Commit 5ec16a85 authored by Andy Adamson's avatar Andy Adamson Committed by Trond Myklebust
Browse files

NFSv4.1 Use clientid management rpc_clnt for secinfo 



As per RFC 3530 and RFC 5661 Security Considerations

Commit 4edaa308 "NFS: Use "krb5i" to establish NFSv4 state whenever possible"
uses the nfs_client cl_rpcclient for all clientid management operations.

Signed-off-by: default avatarAndy Adamson <andros@netapp.com>
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent bc4b2a86

fs/nfs/nfs4proc.c

+6 −1
Original line number Diff line number Diff line
@@ -5794,6 +5794,10 @@ int nfs4_proc_fs_locations(struct rpc_clnt *client, struct inode *dir, 
	return err;

}



/**

 * Use the state managment nfs_client cl_rpcclient, which uses krb5i (if

 * possible) as per RFC3530bis and RFC5661 Security Considerations sections

 */

static int _nfs4_proc_secinfo(struct inode *dir, const struct qstr *name, struct nfs4_secinfo_flavors *flavors)

{

	int status;
@@ -5809,9 +5813,10 @@ static int _nfs4_proc_secinfo(struct inode *dir, const struct qstr *name, struct 
		.rpc_argp = &args,

		.rpc_resp = &res,

	};

	struct rpc_clnt *clnt = NFS_SERVER(dir)->nfs_client->cl_rpcclient;



	dprintk("NFS call  secinfo %s\n", name->name);

	status = nfs4_call_sync(NFS_SERVER(dir)->client, NFS_SERVER(dir), &msg, &args.seq_args, &res.seq_res, 0);

	status = nfs4_call_sync(clnt, NFS_SERVER(dir), &msg, &args.seq_args, &res.seq_res, 0);

	dprintk("NFS reply  secinfo: %d\n", status);

	return status;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE