Commit 5eb9f604 authored Jan 30, 2017 by Jeff Layton Committed by Ilya Dryomov Feb 20, 2017

ceph: do a LOOKUP in d_revalidate instead of GETATTR

In commit c3f4688a (ceph: don't set req->r_locked_dir in
ceph_d_revalidate), we changed the code to do a GETATTR instead of a
LOOKUP as the parent info isn't strictly necessary to revalidate the
dentry. What we missed there though is that in order to update the lease
on the dentry after revalidating it, we _do_ need parent info.

Change ceph_d_revalidate back to doing a LOOKUP instead of a GETATTR so
that we can get the parent info in order to update the lease from
ceph_fill_trace. Note that we set req->r_parent here, but we cannot set
the CEPH_MDS_R_PARENT_LOCKED flag as we can't guarantee that it is.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Yan, Zheng <zyan@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

parent cdde7c43

fs/ceph/dir.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -1244,11 +1244,12 @@ static int ceph_d_revalidate(struct dentry *dentry, unsigned int flags)
		return -ECHILD;

		op = ceph_snap(dir) == CEPH_SNAPDIR ?
		CEPH_MDS_OP_LOOKUPSNAP : CEPH_MDS_OP_GETATTR;
		CEPH_MDS_OP_LOOKUPSNAP : CEPH_MDS_OP_LOOKUP;
		req = ceph_mdsc_create_request(mdsc, op, USE_ANY_MDS);
		if (!IS_ERR(req)) {
		req->r_dentry = dget(dentry);
		req->r_num_caps = op == CEPH_MDS_OP_GETATTR ? 1 : 2;
		req->r_num_caps = 2;
		req->r_parent = dir;

		mask = CEPH_STAT_CAP_INODE \| CEPH_CAP_AUTH_SHARED;
		if (ceph_security_xattr_wanted(dir))

Admin message