usb: dwc3: use proper initializers for property entries (5eb5afb0) · Commits · 戴 / test

We should not be reaching into property entries and initialize them by hand, but rather use proper initializer macros. This way we can alter internal representation of property entries with no visible changes to their users. Reported-by:

Marek Szyprowski <m.szyprowski@samsung.com> Tested-by:

Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by:

Dmitry Torokhov <dmitry.torokhov@gmail.com> Acked-by:

Hans de Goede <hdegoede@redhat.com> Acked-by:

Felipe Balbi <balbi@kernel.org> Signed-off-by:

Rafael J. Wysocki <rafael.j.wysocki@intel.com>

drivers/usb/dwc3/host.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -88,10 +88,10 @@ int dwc3_host_init(struct dwc3 *dwc)
		memset(props, 0, sizeof(struct property_entry) * ARRAY_SIZE(props));

		if (dwc->usb3_lpm_capable)
		props[prop_idx++].name = "usb3-lpm-capable";
		props[prop_idx++] = PROPERTY_ENTRY_BOOL("usb3-lpm-capable");

		if (dwc->usb2_lpm_disable)
		props[prop_idx++].name = "usb2-lpm-disable";
		props[prop_idx++] = PROPERTY_ENTRY_BOOL("usb2-lpm-disable");

		/**
		* WORKAROUND: dwc3 revisions <=3.00a have a limitation
		@@ -103,7 +103,7 @@ int dwc3_host_init(struct dwc3 *dwc)
		* This following flag tells XHCI to do just that.
		*/
		if (dwc->revision <= DWC3_REVISION_300A)
		props[prop_idx++].name = "quirk-broken-port-ped";
		props[prop_idx++] = PROPERTY_ENTRY_BOOL("quirk-broken-port-ped");

		if (prop_idx) {
		ret = platform_device_add_properties(xhci, props);

Admin message