s390/vmalloc: fix VMALLOC_START calculation (5eaf436e) · Commits · 戴 / test

With the introduction of the module area on top of the vmalloc area, the calculation of VMALLOC_START in setup_memory_end() function hasn't been adjusted. As a result we got vmalloc area 2 Gb (MODULES_LEN) smaller than it should be and the preceding vmemmap area got extra memory instead. The patch fixes this calculation error although there were no visible negative effects. Apart from that, change 'tmp' variable to 'vmemmap' in memory_end calculation for better readability. Reviewed-by:

Heiko Carstens <heiko.carstens@de.ibm.com> Signed-off-by:

Mikhail Zaslonko <zaslonko@linux.ibm.com> Signed-off-by:

Martin Schwidefsky <schwidefsky@de.ibm.com>

arch/s390/kernel/setup.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -551,7 +551,7 @@ static void __init setup_memory_end(void)
		MODULES_END = vmax;
		MODULES_VADDR = MODULES_END - MODULES_LEN;
		VMALLOC_END = MODULES_VADDR;
		VMALLOC_START = vmax - vmalloc_size;
		VMALLOC_START = VMALLOC_END - vmalloc_size;

		/* Split remaining virtual space between 1:1 mapping & vmemmap array */
		tmp = VMALLOC_START / (PAGE_SIZE + sizeof(struct page));
		@@ -563,7 +563,7 @@ static void __init setup_memory_end(void)
		vmemmap = (struct page *) tmp;

		/* Take care that memory_end is set and <= vmemmap */
		memory_end = min(memory_end ?: max_physmem_end, tmp);
		memory_end = min(memory_end ?: max_physmem_end, (unsigned long)vmemmap);
		#ifdef CONFIG_KASAN
		/* fit in kasan shadow memory region between 1:1 and vmemmap */
		memory_end = min(memory_end, KASAN_SHADOW_START);

Admin message