Commit 5ea79631 authored Mar 25, 2008 by Michael Buesch Committed by Jeff Garzik Mar 25, 2008

b44: Truncate PHY address



Some ROMs on embedded devices store incorrect values for
the PHY address of the ethernet device.
It looks like the number is sign-extended.
Truncate the value by applying the PHY-address mask to it.
The patch was tested on a bcm47xx embedded system (where the bug
triggers) and a bcm4400 PCI card.

Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

parent 6ef2977d

drivers/net/b44.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -2082,6 +2082,11 @@ static int __devinit b44_get_invariants(struct b44 *bp)
		addr = sdev->bus->sprom.et0mac;
		bp->phy_addr = sdev->bus->sprom.et0phyaddr;
		}
		/* Some ROMs have buggy PHY addresses with the high
		* bits set (sign extension?). Truncate them to a
		* valid PHY address. */
		bp->phy_addr &= 0x1F;

		memcpy(bp->dev->dev_addr, addr, 6);

		if (!is_valid_ether_addr(&bp->dev->dev_addr[0])){

Admin message