can: kvaser_usb: Don't send a RESET_CHIP for non-existing channels (5e7e6e0c) · Commits · 戴 / test

Recent Leaf firmware versions (>= 3.1.557) do not allow to send commands for non-existing channels. If a command is sent for a non-existing channel, the firmware crashes. Reported-by:

Christopher Storah <Christopher.Storah@invetech.com.au> Signed-off-by:

Olivier Sobrie <olivier@sobrie.be> Signed-off-by:

Ahmed S. Darwish <ahmed.darwish@valeo.com> Cc: linux-stable <stable@vger.kernel.org> Signed-off-by:

Marc Kleine-Budde <mkl@pengutronix.de>

drivers/net/can/usb/kvaser_usb.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -1503,6 +1503,10 @@ static int kvaser_usb_init_one(struct usb_interface *intf,
		struct kvaser_usb_net_priv *priv;
		int i, err;

		err = kvaser_usb_send_simple_msg(dev, CMD_RESET_CHIP, channel);
		if (err)
		return err;

		netdev = alloc_candev(sizeof(*priv), MAX_TX_URBS);
		if (!netdev) {
		dev_err(&intf->dev, "Cannot alloc candev\n");
		@@ -1607,9 +1611,6 @@ static int kvaser_usb_probe(struct usb_interface *intf,

		usb_set_intfdata(intf, dev);

		for (i = 0; i < MAX_NET_DEVICES; i++)
		kvaser_usb_send_simple_msg(dev, CMD_RESET_CHIP, i);

		err = kvaser_usb_get_software_info(dev);
		if (err) {
		dev_err(&intf->dev,

Admin message