Commit 5e7a99ac authored Mar 22, 2006 by Latchesar Ionkov Committed by Linus Torvalds Mar 22, 2006

[PATCH] v9fs: assign dentry ops to negative dentries



If a file is not found in v9fs_vfs_lookup, the function creates negative
dentry, but doesn't assign any dentry ops.  This leaves the negative entry
in the cache (there is no d_delete to mark it for removal).  If the file is
created outside of the mounted v9fs filesystem, the file shows up in the
directory with weird permissions.

This patch assigns the default v9fs dentry ops to the negative dentry.

Signed-off-by: Latchesar Ionkov <lucho@ionkov.net>
Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 8a2cda00

fs/9p/vfs_inode.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -614,6 +614,7 @@ static struct dentry v9fs_vfs_lookup(struct inode dir, struct dentry *dentry,

		sb = dir->i_sb;
		v9ses = v9fs_inode2v9ses(dir);
		dentry->d_op = &v9fs_dentry_operations;
		dirfid = v9fs_fid_lookup(dentry->d_parent);

		if (!dirfid) {
		@@ -681,8 +682,6 @@ static struct dentry v9fs_vfs_lookup(struct inode dir, struct dentry *dentry,
		goto FreeFcall;

		fid->qid = fcall->params.rstat.stat.qid;

		dentry->d_op = &v9fs_dentry_operations;
		v9fs_stat2inode(&fcall->params.rstat.stat, inode, inode->i_sb);

		d_add(dentry, inode);

Admin message