Commit 5e78abd0 authored Mar 27, 2018 by tamizhr@codeaurora.org Committed by Johannes Berg Mar 29, 2018

cfg80211: fix data type of sta_opmode_info parameter

Currently bw and smps_mode are u8 type value in sta_opmode_info
structure. This values filled in mac80211 from ieee80211_sta_rx_bandwidth
and ieee80211_smps_mode. These enum values are specific to mac80211 and
userspace/cfg80211 doesn't know about that. This will lead to incorrect
result/assumption by the user space application.
Change bw and smps_mode parameters to their respective enums in nl80211.

Signed-off-by: Tamizh chelvam <tamizhr@codeaurora.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent dcbe73ca

include/net/cfg80211.h

+4 −4

Original line number	Diff line number	Diff line
		@@ -3572,15 +3572,15 @@ enum wiphy_opmode_flag {
		/**
		* struct sta_opmode_info - Station's ht/vht operation mode information
		* @changed: contains value from &enum wiphy_opmode_flag
		* @smps_mode: New SMPS mode of a station
		* @bw: new max bandwidth value of a station
		* @smps_mode: New SMPS mode value from &enum nl80211_smps_mode of a station
		* @bw: new max bandwidth value from &enum nl80211_chan_width of a station
		* @rx_nss: new rx_nss value of a station
		*/

		struct sta_opmode_info {
		u32 changed;
		u8 smps_mode;
		u8 bw;
		enum nl80211_smps_mode smps_mode;
		enum nl80211_chan_width bw;
		u8 rx_nss;
		};

Admin message