Unverified Commit 5e6f3ae5 authored Dec 06, 2018 by Linus Walleij Committed by Mark Brown Dec 11, 2018

regulator: fixed: Let core handle GPIO descriptor



Use the gpiod_get() rather than the devm_* version so that the
regulator core can handle the lifecycle of these descriptors.

Fixes: efdfeb07 ("regulator: fixed: Convert to use GPIO descriptor only")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 0edb040d

drivers/regulator/fixed.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -183,7 +183,11 @@ static int reg_fixed_voltage_probe(struct platform_device *pdev)
		*/
		gflags \|= GPIOD_FLAGS_BIT_NONEXCLUSIVE;

		cfg.ena_gpiod = devm_gpiod_get_optional(&pdev->dev, NULL, gflags);
		/*
		* Do not use devm* here: the regulator core takes over the
		* lifecycle management of the GPIO descriptor.
		*/
		cfg.ena_gpiod = gpiod_get_optional(&pdev->dev, NULL, gflags);
		if (IS_ERR(cfg.ena_gpiod))
		return PTR_ERR(cfg.ena_gpiod);

Admin message