Commit 5e6a9471 authored Dec 06, 2019 by Chris Wilson

drm/i915: Check for error before calling cmpxchg()

Only do the locked compare of the existing fence->error if we actually
need to set an error. As we tend to call i915_sw_fence_set_error_once()
unconditionally, it saves on typing to put the common has-error check
into the inline.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191206160428.1503343-1-chris@chris-wilson.co.uk

parent b66ecd04

drivers/gpu/drm/i915/i915_sw_fence.h

+2 −1

Original line number	Diff line number	Diff line
		@@ -112,6 +112,7 @@ static inline void i915_sw_fence_wait(struct i915_sw_fence *fence)
		static inline void
		i915_sw_fence_set_error_once(struct i915_sw_fence *fence, int error)
		{
		if (unlikely(error))
		cmpxchg(&fence->error, 0, error);
		}