Commit 5e3ca2b3 authored Mar 23, 2016 by Javier Martinez Canillas Committed by Mark Brown Mar 28, 2016

regulator: Try to resolve regulators supplies on registration

Commit 6261b06d ("regulator: Defer lookup of supply to regulator_get")
moved the regulator supplies lookup logic from the regulators registration
to the regulators get time.

Unfortunately, that changed the behavior of the regulator core since now a
parent supply with a child regulator marked as always-on, won't be enabled
unless a client driver attempts to get the child regulator during boot.

This patch tries to resolve the parent supply for the already registered
regulators each time that a new regulator is registered. So the regulators
that have child regulators marked as always on will be enabled regardless
if a driver gets the child regulator or not.

That was the behavior before the mentioned commit, since parent supplies
were looked up at regulator registration time instead of during child get.

Since regulator_resolve_supply() checks for rdev->supply, most of the times
it will be a no-op. Errors aren't checked to keep the possible out of order
dependencies which was the motivation for the mentioned commit.

Also, the supply being available will be enforced on regulator get anyways
in case the resolve fails on regulators registration.

Fixes: 6261b06d ("regulator: Defer lookup of supply to regulator_get")
Suggested-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: <stable@vger.kernel.org> # 4.1+

parent f55532a0

drivers/regulator/core.c

+9 −0

Original line number	Diff line number	Diff line
		@@ -3840,6 +3840,11 @@ static void rdev_init_debugfs(struct regulator_dev *rdev)
		&rdev->bypass_count);
		}

		static int regulator_register_resolve_supply(struct device dev, void data)
		{
		return regulator_resolve_supply(dev_to_rdev(dev));
		}

		/**
		* regulator_register - register regulator
		* @regulator_desc: regulator to register
		@@ -3986,6 +3991,10 @@ regulator_register(const struct regulator_desc *regulator_desc,
		}

		rdev_init_debugfs(rdev);

		/* try to resolve regulators supply since a new one was registered */
		class_for_each_device(&regulator_class, NULL, NULL,
		regulator_register_resolve_supply);
		out:
		mutex_unlock(&regulator_list_mutex);
		kfree(config);

Admin message