Commit 5e392739 authored by Pavel Emelyanov's avatar Pavel Emelyanov Committed by David S. Miller
Browse files

netpoll: don't dereference NULL dev from np 



It looks like the dev in netpoll_poll can be NULL - at lease it's
checked at the function beginning. Thus the dev->netde_ops dereference
looks dangerous.

Signed-off-by: default avatarPavel Emelyanov <xemul@openvz.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 74392592

net/core/netpoll.c

+6 −2
Original line number Original line Diff line number Diff line
@@ -175,9 +175,13 @@ static void service_arp_queue(struct netpoll_info *npi) 
void netpoll_poll(struct netpoll *np)

void netpoll_poll(struct netpoll *np)

{

{

	struct net_device *dev = np->dev;

	struct net_device *dev = np->dev;

	const struct net_device_ops *ops = dev->netdev_ops;

	const struct net_device_ops *ops;



	if (!dev || !netif_running(dev))

		return;





	if (!dev || !netif_running(dev) || !ops->ndo_poll_controller)

	ops = dev->netdev_ops;

	if (!ops->ndo_poll_controller)

		return;

		return;





	/* Process pending work on NIC */

	/* Process pending work on NIC */

CRA Git | Maintained and supported by SUSTech CRA and CCSE