Commit 5e1fccc0 authored by Eric W. Biederman's avatar Eric W. Biederman Committed by David S. Miller
Browse files

net: Allow userns root control of the core of the network stack. 



Allow an unpriviled user who has created a user namespace, and then
created a network namespace to effectively use the new network
namespace, by reducing capable(CAP_NET_ADMIN) and
capable(CAP_NET_RAW) calls to be ns_capable(net->user_ns,
CAP_NET_ADMIN), or capable(net->user_ns, CAP_NET_RAW) calls.

Settings that merely control a single network device are allowed.
Either the network device is a logical network device where
restrictions make no difference or the network device is hardware NIC
that has been explicity moved from the initial network namespace.

In general policy and network stack state changes are allowed
while resource control is left unchanged.

Allow ethtool ioctls.

Allow binding to network devices.
Allow setting the socket mark.
Allow setting the socket priority.

Allow setting the network device alias via sysfs.
Allow setting the mtu via sysfs.
Allow changing the network device flags via sysfs.
Allow setting the network device group via sysfs.

Allow the following network device ioctls.
SIOCGMIIPHY
SIOCGMIIREG
SIOCSIFNAME
SIOCSIFFLAGS
SIOCSIFMETRIC
SIOCSIFMTU
SIOCSIFHWADDR
SIOCSIFSLAVE
SIOCADDMULTI
SIOCDELMULTI
SIOCSIFHWBROADCAST
SIOCSMIIREG
SIOCBONDENSLAVE
SIOCBONDRELEASE
SIOCBONDSETHWADDR
SIOCBONDCHANGEACTIVE
SIOCBRADDIF
SIOCBRDELIF
SIOCSHWTSTAMP

Signed-off-by: default avatar"Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 00f70de0

net/core/dev.c

+13 −4
Original line number Diff line number Diff line
@@ -5279,7 +5279,7 @@ int dev_ioctl(struct net *net, unsigned int cmd, void __user *arg) 
	case SIOCGMIIPHY:

	case SIOCGMIIREG:

	case SIOCSIFNAME:

		if (!capable(CAP_NET_ADMIN))

		if (!ns_capable(net->user_ns, CAP_NET_ADMIN))

			return -EPERM;

		dev_load(net, ifr.ifr_name);

		rtnl_lock();
@@ -5300,16 +5300,25 @@ int dev_ioctl(struct net *net, unsigned int cmd, void __user *arg) 
	 *	- require strict serialization.

	 *	- do not return a value

	 */

	case SIOCSIFMAP:

	case SIOCSIFTXQLEN:

		if (!capable(CAP_NET_ADMIN))

			return -EPERM;

		/* fall through */

	/*

	 *	These ioctl calls:

	 *	- require local superuser power.

	 *	- require strict serialization.

	 *	- do not return a value

	 */

	case SIOCSIFFLAGS:

	case SIOCSIFMETRIC:

	case SIOCSIFMTU:

	case SIOCSIFMAP:

	case SIOCSIFHWADDR:

	case SIOCSIFSLAVE:

	case SIOCADDMULTI:

	case SIOCDELMULTI:

	case SIOCSIFHWBROADCAST:

	case SIOCSIFTXQLEN:

	case SIOCSMIIREG:

	case SIOCBONDENSLAVE:

	case SIOCBONDRELEASE:
@@ -5318,7 +5327,7 @@ int dev_ioctl(struct net *net, unsigned int cmd, void __user *arg) 
	case SIOCBRADDIF:

	case SIOCBRDELIF:

	case SIOCSHWTSTAMP:

		if (!capable(CAP_NET_ADMIN))

		if (!ns_capable(net->user_ns, CAP_NET_ADMIN))

			return -EPERM;

		/* fall through */

	case SIOCBONDSLAVEINFOQUERY:

net/core/ethtool.c

+1 −1
Original line number Diff line number Diff line
@@ -1460,7 +1460,7 @@ int dev_ethtool(struct net *net, struct ifreq *ifr) 
	case ETHTOOL_GEEE:

		break;

	default:

		if (!capable(CAP_NET_ADMIN))

		if (!ns_capable(net->user_ns, CAP_NET_ADMIN))

			return -EPERM;

	}

net/core/net-sysfs.c

+10 −5
Original line number Diff line number Diff line
@@ -73,11 +73,12 @@ static ssize_t netdev_store(struct device *dev, struct device_attribute *attr, 
			    const char *buf, size_t len,

			    int (*set)(struct net_device *, unsigned long))

{

	struct net_device *net = to_net_dev(dev);

	struct net_device *netdev = to_net_dev(dev);

	struct net *net = dev_net(netdev);

	unsigned long new;

	int ret = -EINVAL;



	if (!capable(CAP_NET_ADMIN))

	if (!ns_capable(net->user_ns, CAP_NET_ADMIN))

		return -EPERM;



	ret = kstrtoul(buf, 0, &new);
@@ -87,8 +88,8 @@ static ssize_t netdev_store(struct device *dev, struct device_attribute *attr, 
	if (!rtnl_trylock())

		return restart_syscall();



	if (dev_isalive(net)) {

		if ((ret = (*set)(net, new)) == 0)

	if (dev_isalive(netdev)) {

		if ((ret = (*set)(netdev, new)) == 0)

			ret = len;

	}

	rtnl_unlock();
@@ -264,6 +265,9 @@ static ssize_t store_tx_queue_len(struct device *dev, 
				  struct device_attribute *attr,

				  const char *buf, size_t len)

{

	if (!capable(CAP_NET_ADMIN))

		return -EPERM;



	return netdev_store(dev, attr, buf, len, change_tx_queue_len);

}
@@ -271,10 +275,11 @@ static ssize_t store_ifalias(struct device *dev, struct device_attribute *attr, 
			     const char *buf, size_t len)

{

	struct net_device *netdev = to_net_dev(dev);

	struct net *net = dev_net(netdev);

	size_t count = len;

	ssize_t ret;



	if (!capable(CAP_NET_ADMIN))

	if (!ns_capable(net->user_ns, CAP_NET_ADMIN))

		return -EPERM;



	/* ignore trailing newline */

net/core/sock.c

+4 −3
Original line number Diff line number Diff line
@@ -515,7 +515,7 @@ static int sock_bindtodevice(struct sock *sk, char __user *optval, int optlen) 


	/* Sorry... */

	ret = -EPERM;

	if (!capable(CAP_NET_RAW))

	if (!ns_capable(net->user_ns, CAP_NET_RAW))

		goto out;



	ret = -EINVAL;
@@ -696,7 +696,8 @@ set_rcvbuf: 
		break;



	case SO_PRIORITY:

		if ((val >= 0 && val <= 6) || capable(CAP_NET_ADMIN))

		if ((val >= 0 && val <= 6) ||

		    ns_capable(sock_net(sk)->user_ns, CAP_NET_ADMIN))

			sk->sk_priority = val;

		else

			ret = -EPERM;
@@ -813,7 +814,7 @@ set_rcvbuf: 
			clear_bit(SOCK_PASSSEC, &sock->flags);

		break;

	case SO_MARK:

		if (!capable(CAP_NET_ADMIN))

		if (!ns_capable(sock_net(sk)->user_ns, CAP_NET_ADMIN))

			ret = -EPERM;

		else

			sk->sk_mark = val;

CRA Git | Maintained and supported by SUSTech CRA and CCSE