Commit 5dff80bd authored Oct 14, 2020 by Andrey Grodzovsky Committed by Alex Deucher Oct 21, 2020

drm/amd/display: Avoid MST manager resource leak.



On connector destruction call drm_dp_mst_topology_mgr_destroy
to release resources allocated in drm_dp_mst_topology_mgr_init.
Do it only if MST manager was initilized before otherwsie a crash
is seen on driver unload/device unplug.

Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org

parent 0d427f6c

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -5063,6 +5063,13 @@ static void amdgpu_dm_connector_destroy(struct drm_connector *connector)
		struct amdgpu_device *adev = drm_to_adev(connector->dev);
		struct amdgpu_display_manager *dm = &adev->dm;

		/*
		* Call only if mst_mgr was iniitalized before since it's not done
		* for all connector types.
		*/
		if (aconnector->mst_mgr.dev)
		drm_dp_mst_topology_mgr_destroy(&aconnector->mst_mgr);

		#if defined(CONFIG_BACKLIGHT_CLASS_DEVICE) \|\|\
		defined(CONFIG_BACKLIGHT_CLASS_DEVICE_MODULE)

Admin message