Commit 5de79ba8 authored by Bard Liao's avatar Bard Liao Committed by Vinod Koul
Browse files

soundwire: bus: provide correct return value on error 



It seems to be a typo. It makes more sense to return the return value
of sdw_update() instead of the value we want to update.

Signed-off-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200227220949.4013-1-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent ed29a0a6

drivers/soundwire/bus.c

+2 −5
Original line number Diff line number Diff line
@@ -1056,13 +1056,10 @@ static int sdw_initialize_slave(struct sdw_slave *slave) 
	val |= SDW_DP0_INT_PORT_READY | SDW_DP0_INT_BRA_FAILURE;



	ret = sdw_update(slave, SDW_DP0_INTMASK, val, val);

	if (ret < 0) {

	if (ret < 0)

		dev_err(slave->bus->dev,

			"SDW_DP0_INTMASK read failed:%d\n", ret);

		return val;

	}



	return 0;

	return ret;

}



static int sdw_handle_dp0_interrupt(struct sdw_slave *slave, u8 *slave_status)

CRA Git | Maintained and supported by SUSTech CRA and CCSE