Commit 5de23d43 authored by John Stultz's avatar John Stultz Committed by Linus Torvalds
Browse files

proc: add /proc/<pid>/timerslack_ns interface 



This patch provides a proc/PID/timerslack_ns interface which exposes a
task's timerslack value in nanoseconds and allows it to be changed.

This allows power/performance management software to set timer slack for
other threads according to its policy for the thread (such as when the
thread is designated foreground vs.  background activity)

If the value written is non-zero, slack is set to that value.  Otherwise
sets it to the default for the thread.

This interface checks that the calling task has permissions to to use
PTRACE_MODE_ATTACH_FSCREDS on the target task, so that we can ensure
arbitrary apps do not change the timer slack for other apps.

Signed-off-by: default avatarJohn Stultz <john.stultz@linaro.org>
Acked-by: default avatarKees Cook <keescook@chromium.org>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Oren Laadan <orenl@cellrox.com>
Cc: Ruchi Kandoi <kandoiruchi@google.com>
Cc: Rom Lemarchand <romlem@android.com>
Cc: Android Kernel Team <kernel-team@android.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent da8b44d5

Documentation/filesystems/proc.txt

+18 −0
Original line number Diff line number Diff line
@@ -43,6 +43,7 @@ Table of Contents 
  3.7   /proc/<pid>/task/<tid>/children - Information about task children

  3.8   /proc/<pid>/fdinfo/<fd> - Information about opened file

  3.9   /proc/<pid>/map_files - Information about memory mapped files

  3.10  /proc/<pid>/timerslack_ns - Task timerslack value



  4	Configuring procfs

  4.1	Mount options
@@ -1862,6 +1863,23 @@ time one can open(2) mappings from the listings of two processes and 
comparing their inode numbers to figure out which anonymous memory areas

are actually shared.



3.10	/proc/<pid>/timerslack_ns - Task timerslack value

---------------------------------------------------------

This file provides the value of the task's timerslack value in nanoseconds.

This value specifies a amount of time that normal timers may be deferred

in order to coalesce timers and avoid unnecessary wakeups.



This allows a task's interactivity vs power consumption trade off to be

adjusted.



Writing 0 to the file will set the tasks timerslack to the default value.



Valid values are from 0 - ULLONG_MAX



An application setting the value must have PTRACE_MODE_ATTACH_FSCREDS level

permissions on the task specified to change its timerslack_ns value.





------------------------------------------------------------------------------

Configuring procfs

------------------------------------------------------------------------------

fs/proc/base.c

+67 −0
Original line number Diff line number Diff line
@@ -2257,6 +2257,72 @@ static const struct file_operations proc_timers_operations = { 
	.release	= seq_release_private,

};



static ssize_t timerslack_ns_write(struct file *file, const char __user *buf,

					size_t count, loff_t *offset)

{

	struct inode *inode = file_inode(file);

	struct task_struct *p;

	u64 slack_ns;

	int err;



	err = kstrtoull_from_user(buf, count, 10, &slack_ns);

	if (err < 0)

		return err;



	p = get_proc_task(inode);

	if (!p)

		return -ESRCH;



	if (ptrace_may_access(p, PTRACE_MODE_ATTACH_FSCREDS)) {

		task_lock(p);

		if (slack_ns == 0)

			p->timer_slack_ns = p->default_timer_slack_ns;

		else

			p->timer_slack_ns = slack_ns;

		task_unlock(p);

	} else

		count = -EPERM;



	put_task_struct(p);



	return count;

}



static int timerslack_ns_show(struct seq_file *m, void *v)

{

	struct inode *inode = m->private;

	struct task_struct *p;

	int err =  0;



	p = get_proc_task(inode);

	if (!p)

		return -ESRCH;



	if (ptrace_may_access(p, PTRACE_MODE_ATTACH_FSCREDS)) {

		task_lock(p);

		seq_printf(m, "%llu\n", p->timer_slack_ns);

		task_unlock(p);

	} else

		err = -EPERM;



	put_task_struct(p);



	return err;

}



static int timerslack_ns_open(struct inode *inode, struct file *filp)

{

	return single_open(filp, timerslack_ns_show, inode);

}



static const struct file_operations proc_pid_set_timerslack_ns_operations = {

	.open		= timerslack_ns_open,

	.read		= seq_read,

	.write		= timerslack_ns_write,

	.llseek		= seq_lseek,

	.release	= single_release,

};



static int proc_pident_instantiate(struct inode *dir,

	struct dentry *dentry, struct task_struct *task, const void *ptr)

{
@@ -2831,6 +2897,7 @@ static const struct pid_entry tgid_base_stuff[] = { 
#ifdef CONFIG_CHECKPOINT_RESTORE

	REG("timers",	  S_IRUGO, proc_timers_operations),

#endif

	REG("timerslack_ns", S_IRUGO|S_IWUGO, proc_pid_set_timerslack_ns_operations),

};



static int proc_tgid_base_readdir(struct file *file, struct dir_context *ctx)

CRA Git | Maintained and supported by SUSTech CRA and CCSE