Commit 5dc8cdce authored Mar 26, 2019 by Sergey Matyukevich Committed by Johannes Berg Apr 26, 2019

mac80211/cfg80211: update bss channel on channel switch



FullMAC STAs have no way to update bss channel after CSA channel switch
completion. As a result, user-space tools may provide inconsistent
channel info. For instance, consider the following two commands:
$ sudo iw dev wlan0 link
$ sudo iw dev wlan0 info
The latter command gets channel info from the hardware, so most probably
its output will be correct. However the former command gets channel info
from scan cache, so its output will contain outdated channel info.
In fact, current bss channel info will not be updated until the
next [re-]connect.

Note that mac80211 STAs have a workaround for this, but it requires
access to internal cfg80211 data, see ieee80211_chswitch_work:

	/* XXX: shouldn't really modify cfg80211-owned data! */
	ifmgd->associated->channel = sdata->csa_chandef.chan;

This patch suggests to convert mac80211 workaround into cfg80211 behavior
and to update current bss channel in cfg80211_ch_switch_notify.

Signed-off-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent c2b17948

net/mac80211/mlme.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -1188,9 +1188,6 @@ static void ieee80211_chswitch_work(struct work_struct *work)
		goto out;
		}

		/* XXX: shouldn't really modify cfg80211-owned data! */
		ifmgd->associated->channel = sdata->csa_chandef.chan;

		ifmgd->csa_waiting_bcn = true;

		ieee80211_sta_reset_beacon_monitor(sdata);

net/wireless/nl80211.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -15731,6 +15731,11 @@ void cfg80211_ch_switch_notify(struct net_device *dev,

		wdev->chandef = *chandef;
		wdev->preset_chandef = *chandef;

		if (wdev->iftype == NL80211_IFTYPE_STATION &&
		!WARN_ON(!wdev->current_bss))
		wdev->current_bss->pub.channel = chandef->chan;

		nl80211_ch_switch_notify(rdev, dev, chandef, GFP_KERNEL,
		NL80211_CMD_CH_SWITCH_NOTIFY, 0);
		}

Admin message