Commit 5dbaeb87 authored by Liu Jian's avatar Liu Jian Committed by David S. Miller
Browse files

mlxsw: destroy workqueue when trap_register in mlxsw_emad_init 



When mlxsw_core_trap_register fails in mlxsw_emad_init,
destroy_workqueue() shouled be called to destroy mlxsw_core->emad_wq.

Fixes: d965465b ("mlxsw: core: Fix possible deadlock")
Signed-off-by: default avatarLiu Jian <liujian56@huawei.com>
Reviewed-by: default avatarIdo Schimmel <idosch@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6790711f

drivers/net/ethernet/mellanox/mlxsw/core.c

+2 −1
Original line number Diff line number Diff line
@@ -710,7 +710,7 @@ static int mlxsw_emad_init(struct mlxsw_core *mlxsw_core) 
	err = mlxsw_core_trap_register(mlxsw_core, &mlxsw_emad_rx_listener,

				       mlxsw_core);

	if (err)

		return err;

		goto err_trap_register;



	err = mlxsw_core->driver->basic_trap_groups_set(mlxsw_core);

	if (err)
@@ -722,6 +722,7 @@ static int mlxsw_emad_init(struct mlxsw_core *mlxsw_core) 
err_emad_trap_set:

	mlxsw_core_trap_unregister(mlxsw_core, &mlxsw_emad_rx_listener,

				   mlxsw_core);

err_trap_register:

	destroy_workqueue(mlxsw_core->emad_wq);

	return err;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE