Commit 5dba5175 authored Oct 19, 2019 by Chris Goldsworthy Committed by Rob Herring Oct 23, 2019

of: reserved_mem: add missing of_node_put() for proper ref-counting



Commit d698a388 ("of: reserved-memory: ignore disabled memory-region
nodes") added an early return in of_reserved_mem_device_init_by_idx(), but
didn't call of_node_put() on a device_node whose ref-count was incremented
in the call to of_parse_phandle() preceding the early exit.

Fixes: d698a388 ("of: reserved-memory: ignore disabled memory-region nodes")
Signed-off-by: Chris Goldsworthy <cgoldswo@codeaurora.org>
Cc: stable@vger.kernel.org
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Rob Herring <robh@kernel.org>

parent e13de8fe

drivers/of/of_reserved_mem.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -324,8 +324,10 @@ int of_reserved_mem_device_init_by_idx(struct device *dev,
		if (!target)
		return -ENODEV;

		if (!of_device_is_available(target))
		if (!of_device_is_available(target)) {
		of_node_put(target);
		return 0;
		}

		rmem = __find_rmem(target);
		of_node_put(target);

Admin message