Commit 5db43128 authored by Rickard Strandqvist's avatar Rickard Strandqvist Committed by Scott Wood
Browse files

powerpc/qe: Use strlcpy() 



Replace strcpy and strncpy with strlcpy to avoid strings that are too
big, or lack null termination.

Signed-off-by: default avatarRickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
[scottwood@freescale.com: cleaned up commit message]
Signed-off-by: default avatarScott Wood <scottwood@freescale.com>
parent 8ac6e995

arch/powerpc/sysdev/qe_lib/qe.c

+3 −3
Original line number Diff line number Diff line
@@ -497,7 +497,7 @@ int qe_upload_firmware(const struct qe_firmware *firmware) 
	 * saved microcode information and put in the new.

	 */

	memset(&qe_firmware_info, 0, sizeof(qe_firmware_info));

	strcpy(qe_firmware_info.id, firmware->id);

	strlcpy(qe_firmware_info.id, firmware->id, sizeof(qe_firmware_info.id));

	qe_firmware_info.extended_modes = firmware->extended_modes;

	memcpy(qe_firmware_info.vtraps, firmware->vtraps,

		sizeof(firmware->vtraps));
@@ -583,8 +583,8 @@ struct qe_firmware_info *qe_get_firmware_info(void) 
	/* Copy the data into qe_firmware_info*/

	sprop = of_get_property(fw, "id", NULL);

	if (sprop)

		strncpy(qe_firmware_info.id, sprop,

			sizeof(qe_firmware_info.id) - 1);

		strlcpy(qe_firmware_info.id, sprop,

			sizeof(qe_firmware_info.id));



	prop = of_find_property(fw, "extended-modes", NULL);

	if (prop && (prop->length == sizeof(u64))) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE