Commit 5d9c6b8a authored by Julia Lawall's avatar Julia Lawall Committed by Bjorn Helgaas
Browse files

PCI: pnv_php: Add missing of_node_put()

The device node iterators perform an of_node_get() on each iteration, so a
jump out of the loop requires an of_node_put().

The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr

):

// <smpl>
@@
expression root,e;
local idexpression child;
iterator name for_each_child_of_node;
@@

 for_each_child_of_node(root, child) {
   ... when != of_node_put(child)
       when != e = child
+  of_node_put(child);
?  break;
   ...
}
... when != child
// </smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent d22b3621
Loading
Loading
Loading
Loading
+6 −2
Original line number Diff line number Diff line
@@ -220,13 +220,17 @@ static int pnv_php_populate_changeset(struct of_changeset *ocs,

	for_each_child_of_node(dn, child) {
		ret = of_changeset_attach_node(ocs, child);
		if (ret)
		if (ret) {
			of_node_put(child);
			break;
		}

		ret = pnv_php_populate_changeset(ocs, child);
		if (ret)
		if (ret) {
			of_node_put(child);
			break;
		}
	}

	return ret;
}