cifs: ensure that uncached writes handle unmapped areas correctly (5d81de8e) · Commits · 戴 / test

It's possible for userland to pass down an iovec via writev() that has a bogus user pointer in it. If that happens and we're doing an uncached write, then we can end up getting less bytes than we expect from the call to iov_iter_copy_from_user. This is CVE-2014-0069 cifs_iovec_write isn't set up to handle that situation however. It'll blindly keep chugging through the page array and not filling those pages with anything useful. Worse yet, we'll later end up with a negative number in wdata->tailsz, which will confuse the sending routines and cause an oops at the very least. Fix this by having the copy phase of cifs_iovec_write stop copying data in this situation and send the last write as a short one. At the same time, we want to avoid sending a zero-length write to the server, so break out of the loop and set rc to -EFAULT if that happens. This also allows us to handle the case where no address in the iovec is valid. [Note: Marking this for stable on v3.4+ kernels, but kernels as old as v2.6.38 may have a similar problem and may need similar fix] Cc: <stable@vger.kernel.org> # v3.4+ Reviewed-by:

Pavel Shilovsky <piastry@etersoft.ru> Reported-by:

Al Viro <viro@zeniv.linux.org.uk> Signed-off-by:

Jeff Layton <jlayton@redhat.com> Signed-off-by:

Steve French <smfrench@gmail.com>

fs/cifs/file.c

+34 −3

Original line number	Diff line number	Diff line
		@@ -2389,7 +2389,7 @@ cifs_iovec_write(struct file file, const struct iovec iov,
		unsigned long nr_segs, loff_t *poffset)
		{
		unsigned long nr_pages, i;
		size_t copied, len, cur_len;
		size_t bytes, copied, len, cur_len;
		ssize_t total_written = 0;
		loff_t offset;
		struct iov_iter it;
		@@ -2444,14 +2444,45 @@ cifs_iovec_write(struct file file, const struct iovec iov,

		save_len = cur_len;
		for (i = 0; i < nr_pages; i++) {
		copied = min_t(const size_t, cur_len, PAGE_SIZE);
		bytes = min_t(const size_t, cur_len, PAGE_SIZE);
		copied = iov_iter_copy_from_user(wdata->pages[i], &it,
		0, copied);
		0, bytes);
		cur_len -= copied;
		iov_iter_advance(&it, copied);
		/*
		* If we didn't copy as much as we expected, then that
		* may mean we trod into an unmapped area. Stop copying
		* at that point. On the next pass through the big
		* loop, we'll likely end up getting a zero-length
		* write and bailing out of it.
		*/
		if (copied < bytes)
		break;
		}
		cur_len = save_len - cur_len;

		/*
		* If we have no data to send, then that probably means that
		* the copy above failed altogether. That's most likely because
		* the address in the iovec was bogus. Set the rc to -EFAULT,
		* free anything we allocated and bail out.
		*/
		if (!cur_len) {
		for (i = 0; i < nr_pages; i++)
		put_page(wdata->pages[i]);
		kfree(wdata);
		rc = -EFAULT;
		break;
		}

		/*
		* i + 1 now represents the number of pages we actually used in
		* the copy phase above. Bring nr_pages down to that, and free
		* any pages that we didn't use.
		*/
		for ( ; nr_pages > i + 1; nr_pages--)
		put_page(wdata->pages[nr_pages - 1]);

		wdata->sync_mode = WB_SYNC_ALL;
		wdata->nr_pages = nr_pages;
		wdata->offset = (__u64)offset;

Admin message