mm/migrate.c: check pagelist in move_pages_and_store_status() (5d7ae891) · Commits · 戴 / test

When pagelist is empty, it is not necessary to do the move and store. Also it consolidate the empty list check in one place. Signed-off-by:

mm/migrate.c

+3 −6

Original line number	Diff line number	Diff line
		@@ -1518,9 +1518,6 @@ static int do_move_pages_to_node(struct mm_struct *mm,
		{
		int err;

		if (list_empty(pagelist))
		return 0;

		err = migrate_pages(pagelist, alloc_new_node_page, NULL, node,
		MIGRATE_SYNC, MR_SYSCALL);
		if (err)
		@@ -1608,6 +1605,9 @@ static int move_pages_and_store_status(struct mm_struct *mm, int node,
		{
		int err;

		if (list_empty(pagelist))
		return 0;

		err = do_move_pages_to_node(mm, pagelist, node);
		if (err) {
		/*
		@@ -1705,9 +1705,6 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes,
		current_node = NUMA_NO_NODE;
		}
		out_flush:
		if (list_empty(&pagelist))
		return err;

		/* Make sure we do not overwrite the existing error */
		err1 = move_pages_and_store_status(mm, current_node, &pagelist,
		status, start, i, nr_pages);