Commit 5d6dec6f authored Jul 01, 2017 by Kees Cook Committed by Ingo Molnar Jul 02, 2017

locking/refcount: Remove the half-implemented refcount_sub() API



CONFIG_REFCOUNT_FULL=y (correctly) does not provide a refcount_sub(),
which should not be part of proper refcount design patterns.

Remove the erroneous extern and the later !CONFIG_REFCOUNT_FULL
accidental implementation.

Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: Elena Reshetova <elena.reshetova@intel.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: 29dee3c0 ("locking/refcounts: Out-of-line everything")
Link: http://lkml.kernel.org/r/20170701180129.GA17405@beast


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent fd25d19f

include/linux/refcount.h

+0 −6

Original line number	Diff line number	Diff line
		@@ -49,7 +49,6 @@ extern __must_check bool refcount_inc_not_zero(refcount_t *r);
		extern void refcount_inc(refcount_t *r);

		extern __must_check bool refcount_sub_and_test(unsigned int i, refcount_t *r);
		extern void refcount_sub(unsigned int i, refcount_t *r);

		extern __must_check bool refcount_dec_and_test(refcount_t *r);
		extern void refcount_dec(refcount_t *r);
		@@ -79,11 +78,6 @@ static inline __must_check bool refcount_sub_and_test(unsigned int i, refcount_t
		return atomic_sub_and_test(i, &r->refs);
		}

		static inline void refcount_sub(unsigned int i, refcount_t *r)
		{
		atomic_sub(i, &r->refs);
		}

		static inline __must_check bool refcount_dec_and_test(refcount_t *r)
		{
		return atomic_dec_and_test(&r->refs);

Admin message