ARM: S5PV210: serial: Fix section mismatch warning (5d66ceee) · Commits · 戴 / test

Rename the structure to avoid the following warning: WARNING: drivers/serial/built-in.o(.data+0x534): Section mismatch in reference from the variable s5p_serial_drv to the function .devexit.text:s3c24xx_serial_remove() The variable s5p_serial_drv references the function __devexit s3c24xx_serial_remove() If the reference is valid then annotate the variable with __exit* (see linux/init.h) or name the variable: *driver, *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console, Signed-off-by:

Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by:

Joonyoung Shim <jy0922.shim@samsung.com> Signed-off-by:

Ben Dooks <ben-linux@fluff.org>

drivers/serial/s5pv210.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -119,7 +119,7 @@ static int s5p_serial_probe(struct platform_device *pdev)
		return s3c24xx_serial_probe(pdev, s5p_uart_inf[pdev->id]);
		}

		static struct platform_driver s5p_serial_drv = {
		static struct platform_driver s5p_serial_driver = {
		.probe = s5p_serial_probe,
		.remove = __devexit_p(s3c24xx_serial_remove),
		.driver = {
		@@ -130,19 +130,19 @@ static struct platform_driver s5p_serial_drv = {

		static int __init s5pv210_serial_console_init(void)
		{
		return s3c24xx_serial_initconsole(&s5p_serial_drv, s5p_uart_inf);
		return s3c24xx_serial_initconsole(&s5p_serial_driver, s5p_uart_inf);
		}

		console_initcall(s5pv210_serial_console_init);

		static int __init s5p_serial_init(void)
		{
		return s3c24xx_serial_init(&s5p_serial_drv, *s5p_uart_inf);
		return s3c24xx_serial_init(&s5p_serial_driver, *s5p_uart_inf);
		}

		static void __exit s5p_serial_exit(void)
		{
		platform_driver_unregister(&s5p_serial_drv);
		platform_driver_unregister(&s5p_serial_driver);
		}

		module_init(s5p_serial_init);

Admin message