NFSv4: Ensure the delegation cred is pinned when we call delegreturn (5d63944f) · Commits · 戴 / test

Ensure we don't release the delegation cred during the call to nfs4_proc_delegreturn(). Fixes: ("NFSv4: Fix races between open and delegreturn") Signed-off-by:

Trond Myklebust <trond.myklebust@hammerspace.com> Signed-off-by:

Anna Schumaker <Anna.Schumaker@Netapp.com>

fs/nfs/delegation.c

+8 −3

Original line number	Diff line number	Diff line
		@@ -255,13 +255,18 @@ void nfs_inode_reclaim_delegation(struct inode inode, const struct cred cred,

		static int nfs_do_return_delegation(struct inode inode, struct nfs_delegation delegation, int issync)
		{
		const struct cred *cred;
		int res = 0;

		if (!test_bit(NFS_DELEGATION_REVOKED, &delegation->flags))
		res = nfs4_proc_delegreturn(inode,
		delegation->cred,
		if (!test_bit(NFS_DELEGATION_REVOKED, &delegation->flags)) {
		spin_lock(&delegation->lock);
		cred = get_cred(delegation->cred);
		spin_unlock(&delegation->lock);
		res = nfs4_proc_delegreturn(inode, cred,
		&delegation->stateid,
		issync);
		put_cred(cred);
		}
		return res;
		}

Admin message