3c52x: remove IRQF_SAMPLE_RANDOM from legacy MCA drivers. (5d6076bb) · Commits · 戴 / test

If you are genuinely using one of these legacy MCA drivers then you are tragically on hardware where you really don't have the extra CPU cycles to be wasting on this. In addition, it makes two less cases for people to inadvertently blindly copy flags from without explicitly thinking whether it makes sense -- see the addition to feature-removal.txt as per commit . Signed-off-by:

Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/3c523.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -287,7 +287,7 @@ static int elmc_open(struct net_device *dev)

		elmc_id_attn586(); /* disable interrupts */

		ret = request_irq(dev->irq, elmc_interrupt, IRQF_SHARED \| IRQF_SAMPLE_RANDOM,
		ret = request_irq(dev->irq, elmc_interrupt, IRQF_SHARED,
		dev->name, dev);
		if (ret) {
		pr_err("%s: couldn't get irq %d\n", dev->name, dev->irq);

drivers/net/3c527.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -443,7 +443,7 @@ static int __init mc32_probe1(struct net_device *dev, int slot)
		* Grab the IRQ
		*/

		err = request_irq(dev->irq, mc32_interrupt, IRQF_SHARED \| IRQF_SAMPLE_RANDOM, DRV_NAME, dev);
		err = request_irq(dev->irq, mc32_interrupt, IRQF_SHARED, DRV_NAME, dev);
		if (err) {
		release_region(dev->base_addr, MC32_IO_EXTENT);
		pr_err("%s: unable to get IRQ %d.\n", DRV_NAME, dev->irq);

Admin message