Commit 5d54f948 authored Jan 22, 2018 by Greg Kroah-Hartman

sysfs: turn WARN() into pr_warn()

It's not good to crash the machine if panic_on_warn() is set just
because someone made a stupid mistake of trying to create a sysfs file
with the same name of an existing one. This makes the automated testing
tools a lot harder to find the real bugs in the kernel.

So just print a warning out and dump the stack to get the attention of
the developer that they did something foolish. Then keep on trucking,
as this should not be a fatal error at all.

Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent a9afc573

fs/sysfs/dir.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -10,6 +10,7 @@
		* Please see Documentation/filesystems/sysfs.txt for more information.
		*/

		#define pr_fmt(fmt) "sysfs: " fmt
		#undef DEBUG

		#include <linux/fs.h>
		@@ -27,8 +28,8 @@ void sysfs_warn_dup(struct kernfs_node parent, const char name)
		if (buf)
		kernfs_path(parent, buf, PATH_MAX);

		WARN(1, KERN_WARNING "sysfs: cannot create duplicate filename '%s/%s'\n",
		buf, name);
		pr_warn("cannot create duplicate filename '%s/%s'\n", buf, name);
		dump_stack();

		kfree(buf);
		}

Admin message