Commit 5d5440a8 authored Mar 22, 2012 by tom.leiming@gmail.com Committed by David S. Miller Mar 22, 2012

usbnet: don't clear urb->dev in tx_complete

URB unlinking is always racing with its completion and tx_complete
may be called before or during running usb_unlink_urb, so tx_complete
must not clear urb->dev since it will be used in unlink path,
otherwise invalid memory accesses or usb device leak may be caused
inside usb_unlink_urb.

Cc: stable@kernel.org
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Oliver Neukum <oliver@neukum.org>
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 0956a8c2

drivers/net/usb/usbnet.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1037,7 +1037,6 @@ static void tx_complete (struct urb *urb)
		}

		usb_autopm_put_interface_async(dev->intf);
		urb->dev = NULL;
		entry->state = tx_done;
		defer_bh(dev, skb, &dev->txq);
		}

Admin message